authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:26:27-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:26:27-07:00
log1c59d3b72cbddefa186ce18bea5cd7e6e0ae4874
tree619d1cbfd9d090e06f037e5987f380490253b9cd
parent1e24b43d3f6eea6333a3c8da6946eb614d00a662
signature Signed by PGP key B5690EEEBB952194

refactor(mobile): keep review default ID helper private (#10000)


2 files changed, 1 insertions(+), 3 deletions(-)

apps/mobile/src/features/review/reviewFileVisibility.test.ts-2
......@@ -1,7 +1,6 @@
11import { describe, expect, it } from "vite-plus/test";
22
33import {
4 getDefaultReviewExpandedFileIds,
54 getValidExplicitReviewFileIds,
65 getValidReviewFileIds,
76 removeReviewFileId,
......@@ -29,7 +28,6 @@ describe("review file visibility", () => {
2928 const files = [makeFile("a.ts"), makeFile("b.ts")];
3029
3130 it("defaults expanded files to every renderable file", () => {
32 expect(getDefaultReviewExpandedFileIds(files)).toEqual(["a.ts", "b.ts"]);
3331 expect(getValidReviewFileIds(files, undefined)).toEqual(["a.ts", "b.ts"]);
3432 });
3533
apps/mobile/src/features/review/reviewFileVisibility.ts+1-1
......@@ -3,7 +3,7 @@ import { useCallback, useMemo } from "react";
33import { updateReviewExpandedFileIds, updateReviewViewedFileIds } from "./reviewState";
44import type { ReviewRenderableFile } from "./reviewModel";
55
6export function getDefaultReviewExpandedFileIds(
6function getDefaultReviewExpandedFileIds(
77 files: ReadonlyArray<ReviewRenderableFile>,
88): ReadonlyArray<string> {
99 return files.map((file) => file.id);