From 4fb04fe7fae566cc91ab810888b3232f274a00cf Mon Sep 17 00:00:00 2001 From: Yash Singh Date: Tue, 6 Oct 2026 04:33:40 -0500 Subject: [PATCH] fix(desktop): use the crypto service for screenshot IDs (#16415) --- apps/desktop/src/preview/Manager.ts | 3 ++- .../src/sourceControl/SourceControlRepositoryService.test.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/desktop/src/preview/Manager.ts b/apps/desktop/src/preview/Manager.ts index 10bb0d299d3024295f792f4be5b348bb3c84fe41..fb84d45ad09b917d03771626c05e4b8fb7b9813f 100644 --- a/apps/desktop/src/preview/Manager.ts +++ b/apps/desktop/src/preview/Manager.ts @@ -2974,7 +2974,8 @@ const makeNativeOperations = Effect.fn("PreviewManager.makeOperations")(function wc, ), ]); - const id = `browser-screenshot-${artifactSiteSlug(wc.getURL())}-${millis.toString(36)}-${NodeCrypto.randomUUID().slice(0, 8)}`; + const uuid = yield* crypto.randomUUIDv4.pipe(Effect.orDie); + const id = `browser-screenshot-${artifactSiteSlug(wc.getURL())}-${millis.toString(36)}-${uuid.slice(0, 8)}`; const artifactPath = path.join(resolvedArtifactDirectory, `${id}.png`); const data = image.toPNG(); yield* fileSystem.makeDirectory(resolvedArtifactDirectory, { recursive: true }).pipe( diff --git a/apps/server/src/sourceControl/SourceControlRepositoryService.test.ts b/apps/server/src/sourceControl/SourceControlRepositoryService.test.ts index d2ec39fff3e12576ef6f25d1ee8d73f814dc70ef..3495b2270b3e8c012298e15fa3d892b02382e2ad 100644 --- a/apps/server/src/sourceControl/SourceControlRepositoryService.test.ts +++ b/apps/server/src/sourceControl/SourceControlRepositoryService.test.ts @@ -331,7 +331,7 @@ it.effect.each(["--bare", "source.git"])( }); assert.strictEqual(result.cwd, destinationPath); assert.isTrue(yield* fs.exists(path.join(destinationPath, ".git"))); - }).pipe(Effect.provide(makeLayer({ git: { execute: git.execute } }))); + }).pipe(Effect.provide(layer({ git: { execute: git.execute } }))); }).pipe( Effect.provide( GitVcsDriver.layer.pipe( -- 2.54.0