From 72d94087b460e8d3d76572ed59fe935b80eb41a1 Mon Sep 17 00:00:00 2001 From: oliver <97427849+flamboh@users.noreply.github.com> Date: Mon, 7 Sep 2026 12:57:52 -0700 Subject: [PATCH] fix(web): restore settled PR colors on hover (#10023) --- apps/web/src/components/Sidebar.tsx | 4 +--- apps/web/src/components/ThreadStatusIndicators.test.ts | 6 ++++-- apps/web/src/components/ThreadStatusIndicators.tsx | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/apps/web/src/components/Sidebar.tsx b/apps/web/src/components/Sidebar.tsx index 5df4a9ea8b8b697e7a7fddedb4dd02f881df1543..5182ee4d783ea0b6a7a0923b95324c45c2a374f6 100644 --- a/apps/web/src/components/Sidebar.tsx +++ b/apps/web/src/components/Sidebar.tsx @@ -1468,9 +1468,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: { // number from reflowing as PR states stream in. "shrink-0 text-xs tabular-nums hover:underline", variant === "slim" && variantAction === "unsettle" - ? props.isActive - ? "text-secondary-label" - : cn("text-secondary-label transition-colors", settledPrHoverClass) + ? cn("text-secondary-label transition-colors", settledPrHoverClass) : prStatus.colorClass, )} aria-label={prStatus.tooltip} diff --git a/apps/web/src/components/ThreadStatusIndicators.test.ts b/apps/web/src/components/ThreadStatusIndicators.test.ts index 7dd8c79c9b4626ecfbc7f12f07d8aac7e869e3f7..0afa45d27d0ad764a2e5790e4d6dad3186e26eb4 100644 --- a/apps/web/src/components/ThreadStatusIndicators.test.ts +++ b/apps/web/src/components/ThreadStatusIndicators.test.ts @@ -125,10 +125,12 @@ describe("settledPrHoverColorClass", () => { ["merged", "text-violet-600"], ["closed", "text-red-600"], ] as const)("restores the %s pull request color on row hover", (state, colorClass) => { - expect(settledPrHoverColorClass(state)).toContain(`group-hover/v2-row:${colorClass}`); + expect(settledPrHoverColorClass(state)).toContain(`group-hover/sidebar-row:${colorClass}`); }); it("keeps draft pull requests gray on row hover", () => { - expect(settledPrHoverColorClass("open", true)).toContain("group-hover/v2-row:text-zinc-500"); + expect(settledPrHoverColorClass("open", true)).toContain( + "group-hover/sidebar-row:text-zinc-500", + ); }); }); diff --git a/apps/web/src/components/ThreadStatusIndicators.tsx b/apps/web/src/components/ThreadStatusIndicators.tsx index 76815441992754f72e1eaa0ac5f116f67fe36cd5..afe56608eda553115984e847e1089a6cc32a0dd3 100644 --- a/apps/web/src/components/ThreadStatusIndicators.tsx +++ b/apps/web/src/components/ThreadStatusIndicators.tsx @@ -86,13 +86,13 @@ export function settledPrHoverColorClass( switch (state) { case "open": if (isDraft) { - return "group-hover/v2-row:text-zinc-500 dark:group-hover/v2-row:text-zinc-400/80"; + return "group-hover/sidebar-row:text-zinc-500 dark:group-hover/sidebar-row:text-zinc-400/80"; } - return "group-hover/v2-row:text-emerald-600 dark:group-hover/v2-row:text-emerald-300/90"; + return "group-hover/sidebar-row:text-emerald-600 dark:group-hover/sidebar-row:text-emerald-300/90"; case "merged": - return "group-hover/v2-row:text-violet-600 dark:group-hover/v2-row:text-violet-300/90"; + return "group-hover/sidebar-row:text-violet-600 dark:group-hover/sidebar-row:text-violet-300/90"; case "closed": - return "group-hover/v2-row:text-red-600 dark:group-hover/v2-row:text-red-300/90"; + return "group-hover/sidebar-row:text-red-600 dark:group-hover/sidebar-row:text-red-300/90"; } } -- 2.54.0