From 8ac57f79444ede3f43b8bfbf8455bca23fa50624 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Fri, 17 Apr 2026 16:40:43 -0700 Subject: [PATCH] Guard release workflow jobs on upstream success (#2147) --- .github/workflows/release.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index eaa8383616749573f5a908cc0f64ab7e4a14d4ae..36ec0367dbe8ec3a1376a0ad0043366133f93b85 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -171,7 +171,7 @@ jobs: build: name: Build ${{ matrix.label }} needs: preflight - if: ${{ !failure() && !cancelled() }} + if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' }} runs-on: ${{ matrix.runner }} timeout-minutes: 30 strategy: @@ -354,7 +354,7 @@ jobs: publish_cli: name: Publish CLI to npm needs: [preflight, build] - if: ${{ !failure() && !cancelled() }} + if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.build.result == 'success' }} runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 timeout-minutes: 10 steps: @@ -389,7 +389,7 @@ jobs: release: name: Publish GitHub Release needs: [preflight, build, publish_cli] - if: ${{ !failure() && !cancelled() }} + if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.build.result == 'success' && needs.publish_cli.result == 'success' }} runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404 timeout-minutes: 10 steps: @@ -499,7 +499,7 @@ jobs: finalize: name: Finalize release - if: ${{ !failure() && !cancelled() && needs.preflight.outputs.release_channel == 'stable' }} + if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.release.result == 'success' && needs.preflight.outputs.release_channel == 'stable' }} needs: [preflight, release] runs-on: blacksmith-8vcpu-ubuntu-2404 timeout-minutes: 10 -- 2.54.0