authorgravatar for 269035359+t3-code[bot]@users.noreply.github.comt3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> 2026-08-31 09:53:26-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-08-31 09:53:26-07:00
logad38700ac678b8c8a0310d434a44d94a7ee6a47f
treec0ffb4cae593b5f0025c778304ee4e0cb2f0c2b5
parentf86c5e8c8700b76250ed1073700a5b9db47e2d57
signature Signed by PGP key B5690EEEBB952194

chore(macroscope): review diagnostic overrides (#8917)

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>

2 files changed, 5 insertions(+), 0 deletions(-)

.macroscope/approvability.md+4
......@@ -1,3 +1,7 @@
11Use Macroscope's default approvability criteria.
22
33Additionally, any pull request that changes product defaults is not auto-approvable and requires human review.
4
5Any pull request that adds or broadens a directive that disables or suppresses a lint,
6type-checker, LSP, or other static-analysis diagnostic is not auto-approvable and requires
7human review. This includes file-level, line-level, and configuration-level overrides.
.macroscope/check-run-agents/effect-service-conventions.md+1
......@@ -82,6 +82,7 @@ Review changed TypeScript and directly affected call sites for the conventions b
8282## Change discipline
8383
8484- Preserve useful comments, invariants, and specification documentation while moving code.
85- Require every new or broadened directive that disables or suppresses a lint, type-checker, LSP, or other static-analysis diagnostic to have an adjacent comment explaining why that diagnostic must be disabled there. The directive itself is not an explanation. Report a missing explanation as a concrete violation.
8586- Do not add large tests solely to prove a mechanical refactor. Update existing tests and imports as needed.
8687- If backend behavior changes, require focused tests. Use test implementations/layers for external services only; do not mock out core business logic.
8788- Do not require `Layer.effect`, universal namespace imports, generic `make`/`layer` names for abstract-port implementations, separate error classes for diagnostic-only fields, or new tests for import-only changes.