From fe87502084ad99209a22f801347102ebb29cc65b Mon Sep 17 00:00:00 2001 From: "t3-code[bot]" <269035359+t3-code[bot]@users.noreply.github.com> Date: Thu, 20 Aug 2026 17:52:19 -0400 Subject: [PATCH] fix(contracts): reconcile provider default tests (#7725) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> --- packages/contracts/src/settings.test.ts | 11 ++--------- packages/contracts/src/settings.ts | 3 +-- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/packages/contracts/src/settings.test.ts b/packages/contracts/src/settings.test.ts index 8ff14d959eb151ff1fe141f8c37c64231abbb6da..0f59da5ece14b6e6c086893ee5e679f35028eb34 100644 --- a/packages/contracts/src/settings.test.ts +++ b/packages/contracts/src/settings.test.ts @@ -136,14 +136,6 @@ describe("ServerSettings.providerInstances (slice-2 invariant)", () => { expect(decoded.providers.codex.enabled).toBe(true); }); - it("enables every built-in provider by default", () => { - const decoded = decodeServerSettings({}); - expect(decoded.providers.cursor.enabled).toBe(true); - expect(decoded.providers.claudeAgent.enabled).toBe(true); - expect(decoded.providers.grok.enabled).toBe(true); - expect(decoded.providers.opencode.enabled).toBe(true); - }); - it("decodes a multi-instance map mixing first-party and fork drivers", () => { const decoded = decodeServerSettings({ providerInstances: { @@ -192,13 +184,14 @@ describe("provider enabled defaults", () => { const decoded = decodeServerSettings({}); expect(decoded.providers.codex.enabled).toBe(true); expect(decoded.providers.claudeAgent.enabled).toBe(true); - expect(decoded.providers.cursor.enabled).toBe(false); + expect(decoded.providers.cursor.enabled).toBe(true); expect(decoded.providers.grok.enabled).toBe(false); expect(decoded.providers.opencode.enabled).toBe(false); }); it("derives per-driver defaults from the settings schemas", () => { expect(defaultEnabledForDriver(ProviderDriverKind.make("codex"))).toBe(true); + expect(defaultEnabledForDriver(ProviderDriverKind.make("cursor"))).toBe(true); expect(defaultEnabledForDriver(ProviderDriverKind.make("grok"))).toBe(false); // Unknown fork drivers stay enabled; their own build decides otherwise. expect(defaultEnabledForDriver(ProviderDriverKind.make("ollama"))).toBe(true); diff --git a/packages/contracts/src/settings.ts b/packages/contracts/src/settings.ts index 133358c812e57167a58f96d370b9268ee3642473..0502d303d2496ceaa3488e49f2bf3636ce654831 100644 --- a/packages/contracts/src/settings.ts +++ b/packages/contracts/src/settings.ts @@ -407,8 +407,7 @@ export type ClaudeSettings = typeof ClaudeSettings.Type; export const CursorSettings = makeProviderSettingsSchema( { - // Off by default (like Grok and OpenCode): the binding is not yet - // stable enough to probe on every install. Users opt in from Settings. + // Enabled by default alongside Codex and Claude Agent. enabled: Schema.Boolean.pipe( Schema.withDecodingDefault(Effect.succeed(true)), Schema.annotateKey({ providerSettingsForm: { hidden: true } }), -- 2.54.0