Commit 1550f1b742138df8b31b24e34ddea58c80afb3cc | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-09-05 00:12:34-07:00
committer	GitHub <noreply@github.com> 2026-09-05 00:12:34-07:00
log	1550f1b742138df8b31b24e34ddea58c80afb3cc
tree	bc60c4042e6c5661f1a2d759b493e26fbd8e192a
parent	2fc630c9e85321b7b3963372fd316877a7581639
signature	Signed by PGP key B5690EEEBB952194

test(server): assert the dispatched welcome thread model (#9980)

2 files changed, 9 insertions(+), 13 deletions(-)

apps
- server
  - src
    serverRuntimeStartup.test.ts
    serverRuntimeStartup.ts

apps/server/src/serverRuntimeStartup.test.ts+8-12

 @@ -17,13 +17,6 @@ import * as AnalyticsService from "./telemetry/AnalyticsService.ts";
 import * as ServerRuntimeStartup from "./serverRuntimeStartup.ts";
 import * as GitVcsDriver from "./vcs/GitVcsDriver.ts";
-it("uses the canonical Codex default for the auto-bootstrapped welcome thread", () => {
-  assert.deepStrictEqual(ServerRuntimeStartup.getAutoBootstrapThreadModelSelection(), {
-    instanceId: ProviderInstanceId.make("codex"),
-    model: DEFAULT_MODEL,
-  });
-});
 it.effect("automatic pull only updates enabled, behind, clean default-branch checkouts", () =>
   Effect.gen(function* () {
     const pulled: string[] = [];
 @@ -201,7 +194,10 @@ it.effect("resolveAutoBootstrapWelcomeTargets returns existing project and threa
               id: bootstrapProjectId,
               title: "Startup Project",
               workspaceRoot: "/tmp/startup-project",
-              defaultModelSelection: ServerRuntimeStartup.getAutoBootstrapThreadModelSelection(),
+              defaultModelSelection: {
+                instanceId: ProviderInstanceId.make("codex"),
+                model: DEFAULT_MODEL,
+              },
               scripts: [],
               createdAt: "2026-01-01T00:00:00.000Z",
               updatedAt: "2026-01-01T00:00:00.000Z",
 @@ -298,10 +294,10 @@ it.effect("resolveAutoBootstrapWelcomeTargets creates a project and thread when
       ["project.create", "thread.create"],
     );
     assert.equal("defaultModelSelection" in commands[0]!, false);
-    assert.deepStrictEqual(
+    assert.deepStrictEqual(commands[1]?.modelSelection, {
-      commands[1]?.modelSelection,
+      instanceId: ProviderInstanceId.make("codex"),
-      ServerRuntimeStartup.getAutoBootstrapThreadModelSelection(),
+      model: DEFAULT_MODEL,
-    );
+    });
   }),
 );

apps/server/src/serverRuntimeStartup.ts+1-1

...	@@ -176,7 +176,7 @@ export const launchStartupHeartbeat = recordStartupHeartbeat.pipe(	...	@@ -176,7 +176,7 @@ export const launchStartupHeartbeat = recordStartupHeartbeat.pipe(
176	Effect.asVoid,	176	Effect.asVoid,
177	);	177	);
178		178
179	export const getAutoBootstrapThreadModelSelection = (): ModelSelection => ({	179	const getAutoBootstrapThreadModelSelection = (): ModelSelection => ({
180	instanceId: ProviderInstanceId.make("codex"),	180	instanceId: ProviderInstanceId.make("codex"),
181	model: DEFAULT_MODEL,	181	model: DEFAULT_MODEL,
182	});	182	});