authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:09:23-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:09:23-07:00
log1568b3fd083e198a08bb12353820c1ef99fb3420
tree71c9e58e1356b3b9dafd8649998d87f73a0fff2b
parent32142cff186c607c8cae644927cee8d6c9cba757
signature Signed by PGP key B5690EEEBB952194

refactor(shared): remove unused viewport formatters (#9970)


2 files changed, 1 insertions(+), 25 deletions(-)

packages/shared/src/previewViewport.test.ts+1-14
...@@ -1,11 +1,6 @@...@@ -1,11 +1,6 @@
1import { describe, expect, it } from "vite-plus/test";1import { describe, expect, it } from "vite-plus/test";
22
3import {3import { PREVIEW_VIEWPORT_PRESETS, resolvePreviewViewport } from "./previewViewport.ts";
4 PREVIEW_VIEWPORT_PRESETS,
5 previewViewportLabel,
6 previewViewportPresetOrientation,
7 resolvePreviewViewport,
8} from "./previewViewport.ts";
94
10describe("previewViewport", () => {5describe("previewViewport", () => {
11 it("resolves fill and exact freeform viewports", () => {6 it("resolves fill and exact freeform viewports", () => {
...@@ -59,12 +54,4 @@ describe("previewViewport", () => {...@@ -59,12 +54,4 @@ describe("previewViewport", () => {
59 "Nest Hub Max",54 "Nest Hub Max",
60 ]);55 ]);
61 });56 });
62
63 it("formats settings for compact UI", () => {
64 expect(previewViewportLabel({ _tag: "fill" })).toBe("Fill panel");
65 expect(previewViewportLabel({ _tag: "freeform", width: 393, height: 852 })).toBe("393 × 852");
66 expect(previewViewportPresetOrientation({ _tag: "freeform", width: 852, height: 393 })).toBe(
67 "landscape",
68 );
69 });
70});57});
packages/shared/src/previewViewport.ts-11
...@@ -173,14 +173,3 @@ export function resolvePreviewViewport(...@@ -173,14 +173,3 @@ export function resolvePreviewViewport(
173 height: input.height,173 height: input.height,
174 };174 };
175}175}
176
177export function previewViewportLabel(viewport: PreviewViewportSetting): string {
178 return viewport._tag === "fill" ? "Fill panel" : `${viewport.width} × ${viewport.height}`;
179}
180
181export function previewViewportPresetOrientation(
182 viewport: PreviewViewportSetting,
183): "portrait" | "landscape" | null {
184 if (viewport._tag === "fill" || viewport.width === viewport.height) return null;
185 return viewport.width > viewport.height ? "landscape" : "portrait";
186}