Commit 1735e27d9e5106bbb35d5b1dd10363604a54b69e | the-knife

author	Taras <Taras.Fomin@gmail.com> 2026-07-18 22:05:09+00:00
committer	GitHub <noreply@github.com> 2026-07-19 00:05:09+02:00
log	1735e27d9e5106bbb35d5b1dd10363604a54b69e
tree	3ccd6632b52ebe00aba49d31977fb633bd229551
parent	ebe8afb1df357423a0e036b388af3e739d640205
signature	Signed by PGP key B5690EEEBB952194

Add terminal selection copy action (#2904)

1 files changed, 43 insertions(+), 14 deletions(-)

apps
- web
  - src
    components
    ThreadTerminalDrawer.tsx

apps/web/src/components/ThreadTerminalDrawer.tsx+43-14

 @@ -31,6 +31,7 @@ import {
   useState,
 } from "react";
 import { Popover, PopoverPopup, PopoverTrigger } from "~/components/ui/popover";
+import { writeTextToClipboard } from "~/hooks/useCopyToClipboard";
 import { cn } from "~/lib/utils";
 import { type TerminalContextSelection } from "~/lib/terminalContext";
 import { useOpenInPreferredEditor } from "../editorPreferences";
 @@ -330,7 +331,7 @@ export function TerminalViewport({
   const selectionPointerRef = useRef<{ x: number; y: number } | null>(null);
   const selectionGestureActiveRef = useRef(false);
   const selectionActionRequestIdRef = useRef(0);
-  const selectionActionOpenRef = useRef(false);
+  const selectionActionMenuOpenRef = useRef(false);
   const selectionActionTimerRef = useRef<number | null>(null);
   const keybindingsRef = useRef(keybindings);
   const runtimeEnvKey = useMemo(() => runtimeEnvSignature(runtimeEnv), [runtimeEnv]);
 @@ -417,6 +418,7 @@ export function TerminalViewport({
     const readSelectionAction = (): {
       position: { x: number; y: number };
+      clipboardText: string;
       selection: TerminalContextSelection;
     } | null => {
       const activeTerminal = terminalRef.current;
 @@ -445,6 +447,7 @@ export function TerminalViewport({
       });
       return {
         position,
+        clipboardText: selectionText,
         selection: {
           terminalId,
           terminalLabel: readTerminalLabel(),
 @@ -460,7 +463,7 @@ export function TerminalViewport({
         clearSelectionAction();
         return;
       }
-      if (selectionActionOpenRef.current) {
+      if (selectionActionMenuOpenRef.current) {
         return;
       }
       const nextAction = readSelectionAction();
 @@ -469,20 +472,46 @@ export function TerminalViewport({
         return;
       }
       const requestId = ++selectionActionRequestIdRef.current;
-      selectionActionOpenRef.current = true;
+      selectionActionMenuOpenRef.current = true;
-      try {
+      const clicked = await localApi.contextMenu
-        const clicked = await localApi.contextMenu.show(
+        .show(
-          [{ id: "add-to-chat", label: "Add to chat" }],
+          [
+            { id: "add-to-chat", label: "Add to chat" },
+            { id: "copy", label: "Copy" },
+          ],
           nextAction.position,
-        );
+        )
-        if (requestId !== selectionActionRequestIdRef.current || clicked !== "add-to-chat") {
+        .finally(() => {
+          selectionActionMenuOpenRef.current = false;
+        });
+      if (requestId !== selectionActionRequestIdRef.current || clicked === null) {
+        return;
+      }
+      switch (clicked) {
+        case "add-to-chat":
+          handleAddTerminalContext(nextAction.selection);
+          terminalRef.current?.clearSelection();
+          terminalRef.current?.focus();
+          return;
+        case "copy":
+          try {
+            await writeTextToClipboard(nextAction.clipboardText, "terminal selection");
+          } catch (error) {
+            if (requestId !== selectionActionRequestIdRef.current) {
+              return;
+            }
+            const activeTerminal = terminalRef.current;
+            if (activeTerminal) {
+              writeSystemMessage(
+                activeTerminal,
+                error instanceof Error ? error.message : "Unable to copy terminal selection",
+              );
+            }
+          }
+          if (requestId === selectionActionRequestIdRef.current) {
+            terminalRef.current?.focus();
+          }
           return;
-        }
-        handleAddTerminalContext(nextAction.selection);
-        terminalRef.current?.clearSelection();
-        terminalRef.current?.focus();
-      } finally {
-        selectionActionOpenRef.current = false;
       }
     };