Commit 393d1ffc9ee52696e4b5f226a956e9d4c65b2f6a | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-09-05 00:26:34-07:00
committer	GitHub <noreply@github.com> 2026-09-05 00:26:34-07:00
log	393d1ffc9ee52696e4b5f226a956e9d4c65b2f6a
tree	ed985f915b3c353bb34c6086bbd17779ab96224c
parent	3382b26c4f29bcbc709edf135c5486b7f1e0e211
signature	Signed by PGP key B5690EEEBB952194

refactor(mobile): test terminal palettes through public theme API (#10002)

2 files changed, 8 insertions(+), 21 deletions(-)

apps
- mobile
  - src
    features
    terminal
    terminalTheme.test.ts
    terminalTheme.ts

apps/mobile/src/features/terminal/terminalTheme.test.ts+7-20

 @@ -3,15 +3,11 @@ import { BUILT_IN_THEMES, getThemeColorsForAppearance } from "@t3tools/shared/th
 import { themeColorToNativeColor } from "../../lib/mobileTheme";
-import {
+import { buildGhosttyThemeConfig, getMobileTerminalTheme } from "./terminalTheme";
-  buildGhosttyThemeConfig,
-  getMobileTerminalTheme,
-  getPierreTerminalTheme,
-} from "./terminalTheme";
-describe("getPierreTerminalTheme", () => {
+describe("getMobileTerminalTheme", () => {
-  it("returns the Pierre light terminal palette", () => {
+  it("preserves the default light terminal palette", () => {
-    expect(getPierreTerminalTheme("light")).toMatchObject({
+    expect(getMobileTerminalTheme("t3-code", "light")).toMatchObject({
       background: "#f2f2f7",
       foreground: "#6C6C71",
       cursorForeground: "#009fff",
 @@ -19,23 +15,14 @@ describe("getPierreTerminalTheme", () => {
     });
   });
-  it("returns the Pierre dark terminal palette", () => {
+  it("preserves the default dark terminal palette", () => {
-    expect(getPierreTerminalTheme("dark")).toMatchObject({
+    expect(getMobileTerminalTheme("t3-code", "dark")).toMatchObject({
       background: "#0a0a0a",
       foreground: "#adadb1",
       cursorForeground: "#009fff",
       cursorBackground: "#0a0a0a",
     });
   });
-});
-describe("getMobileTerminalTheme", () => {
-  it("preserves the Pierre terminal for the default theme", () => {
-    for (const scheme of ["light", "dark"] as const) {
-      expect(getMobileTerminalTheme("t3-code", scheme)).toEqual(getPierreTerminalTheme(scheme));
-    }
-  });
   it("applies the selected palette without replacing ANSI status colors", () => {
     const standard = getMobileTerminalTheme("t3-code", "dark");
     const ocean = getMobileTerminalTheme("ocean", "dark");
 @@ -58,7 +45,7 @@ describe("getMobileTerminalTheme", () => {
 describe("buildGhosttyThemeConfig", () => {
   it("serializes theme colors into a ghostty config file", () => {
-    const config = buildGhosttyThemeConfig(getPierreTerminalTheme("dark"));
+    const config = buildGhosttyThemeConfig(getMobileTerminalTheme("t3-code", "dark"));
     expect(config).toContain("background = #0a0a0a");
     expect(config).toContain("foreground = #adadb1");

apps/mobile/src/features/terminal/terminalTheme.ts+1-1

...	@@ -74,7 +74,7 @@ const PIERRE_DARK_THEME: TerminalTheme = {	...	@@ -74,7 +74,7 @@ const PIERRE_DARK_THEME: TerminalTheme = {
74	],	74	],
75	};	75	};
76		76
77	export function getPierreTerminalTheme(scheme: TerminalAppearanceScheme): TerminalTheme {	77	function getPierreTerminalTheme(scheme: TerminalAppearanceScheme): TerminalTheme {
78	return scheme === "light" ? PIERRE_LIGHT_THEME : PIERRE_DARK_THEME;	78	return scheme === "light" ? PIERRE_LIGHT_THEME : PIERRE_DARK_THEME;
79	}	79	}
80		80