authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 01:30:18-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 01:30:18-07:00
log56a2f42b8ce27f5deefaa85a02ae9c1d3b61f309
tree231bc9d2e3b139adb2be96a3fd2af36e9627f5a3
parent91ba05e870603b6bc0649e33973f73d86cbf58c3
signature Signed by PGP key B5690EEEBB952194

refactor(desktop): remove test-only error predicates (#10047)

8 files changed, 0 insertions(+), 18 deletions(-)

apps/desktop/src/backend/DesktopServerExposure.test.ts-3
......@@ -272,8 +272,6 @@ describe("DesktopServerExposure", () => {
272272 modeError,
273273 DesktopServerExposure.DesktopServerExposureModePersistenceError,
274274 );
275 assert.isTrue(DesktopServerExposure.isDesktopServerExposureSetModeError(modeError));
276 assert.isTrue(DesktopServerExposure.isDesktopServerExposureError(modeError));
277275 assert.equal(modeError.mode, "network-accessible");
278276 assert.strictEqual(modeError.cause, settingsFailure);
279277 assert.strictEqual(modeError.cause.cause, diskFailure);
......@@ -290,7 +288,6 @@ describe("DesktopServerExposure", () => {
290288 tailscaleError,
291289 DesktopServerExposure.DesktopTailscaleServePersistenceError,
292290 );
293 assert.isTrue(DesktopServerExposure.isDesktopServerExposureError(tailscaleError));
294291 assert.equal(tailscaleError.enabled, true);
295292 assert.equal(tailscaleError.port, 8443);
296293 assert.strictEqual(tailscaleError.cause, settingsFailure);
apps/desktop/src/backend/DesktopServerExposure.ts-2
......@@ -244,7 +244,6 @@ export const DesktopServerExposureSetModeError = Schema.Union([
244244 DesktopServerExposureModePersistenceError,
245245]);
246246export type DesktopServerExposureSetModeError = typeof DesktopServerExposureSetModeError.Type;
247export const isDesktopServerExposureSetModeError = Schema.is(DesktopServerExposureSetModeError);
248247
249248export const DesktopServerExposureError = Schema.Union([
250249 DesktopServerExposureNoNetworkAddressError,
......@@ -252,7 +251,6 @@ export const DesktopServerExposureError = Schema.Union([
252251 DesktopTailscaleServePersistenceError,
253252]);
254253export type DesktopServerExposureError = typeof DesktopServerExposureError.Type;
255export const isDesktopServerExposureError = Schema.is(DesktopServerExposureError);
256254
257255export interface DesktopServerExposureBackendConfig {
258256 readonly port: number;
apps/desktop/src/ipc/DesktopIpc.test.ts-2
......@@ -41,7 +41,6 @@ describe("DesktopIpc", () => {
4141 const error = yield* Effect.flip(Effect.scoped(ipc.handle(invokeMethod)));
4242
4343 assert.instanceOf(error, DesktopIpc.DesktopIpcRegistrationError);
44 assert.isTrue(DesktopIpc.isDesktopIpcError(error));
4544 assert.strictEqual(error.handlerKind, "invoke");
4645 assert.strictEqual(error.channel, invokeMethod.channel);
4746 assert.strictEqual(error.cause, cause);
......@@ -69,7 +68,6 @@ describe("DesktopIpc", () => {
6968 if (exit._tag === "Success") return;
7069 const error = Cause.squash(exit.cause);
7170 assert.instanceOf(error, DesktopIpc.DesktopIpcUnregistrationError);
72 assert.isTrue(DesktopIpc.isDesktopIpcError(error));
7371 assert.strictEqual(error.handlerKind, "sync");
7472 assert.strictEqual(error.channel, syncMethod.channel);
7573 assert.strictEqual(error.cause, cause);
apps/desktop/src/ipc/DesktopIpc.ts-1
......@@ -55,7 +55,6 @@ export const DesktopIpcError = Schema.Union([
5555 DesktopIpcUnregistrationError,
5656]);
5757export type DesktopIpcError = typeof DesktopIpcError.Type;
58export const isDesktopIpcError = Schema.is(DesktopIpcError);
5958
6059export interface DesktopIpcMethod<E, R> {
6160 readonly channel: string;
apps/desktop/src/preview/BrowserSession.test.ts-6
......@@ -172,8 +172,6 @@ describe("BrowserSession", () => {
172172 const error = yield* browserSessions.getPartition("environment-a").pipe(Effect.flip);
173173
174174 assert.instanceOf(error, BrowserSession.BrowserSessionPartitionDerivationError);
175 assert.isTrue(BrowserSession.isBrowserSessionGetSessionError(error));
176 assert.isTrue(BrowserSession.isBrowserSessionError(error));
177175 assert.equal(error.scope, "environment-a");
178176 assert.strictEqual(error.cause, platformCause);
179177 assert.strictEqual(error.cause.reason.cause, nativeCause);
......@@ -196,8 +194,6 @@ describe("BrowserSession", () => {
196194 const error = yield* browserSessions.getSession("environment-b").pipe(Effect.flip);
197195
198196 assert.instanceOf(error, BrowserSession.BrowserSessionCreationError);
199 assert.isTrue(BrowserSession.isBrowserSessionGetSessionError(error));
200 assert.isTrue(BrowserSession.isBrowserSessionError(error));
201197 assert.equal(error.scope, "environment-b");
202198 assert.equal(error.partition, partition);
203199 assert.strictEqual(error.cause, cause);
......@@ -270,7 +266,6 @@ describe("BrowserSession", () => {
270266 const storageError = yield* browserSessions.clearCookies().pipe(Effect.flip);
271267
272268 assert.instanceOf(storageError, BrowserSession.BrowserSessionStorageClearError);
273 assert.isTrue(BrowserSession.isBrowserSessionError(storageError));
274269 assert.equal(storageError.partition, secondPartition);
275270 assert.strictEqual(storageError.cause, storageCause);
276271 assert.equal(
......@@ -287,7 +282,6 @@ describe("BrowserSession", () => {
287282 const cacheError = yield* browserSessions.clearCache().pipe(Effect.flip);
288283
289284 assert.instanceOf(cacheError, BrowserSession.BrowserSessionCacheClearError);
290 assert.isTrue(BrowserSession.isBrowserSessionError(cacheError));
291285 assert.equal(cacheError.partition, firstPartition);
292286 assert.strictEqual(cacheError.cause, cacheCause);
293287 assert.equal(
apps/desktop/src/preview/BrowserSession.ts-2
......@@ -93,7 +93,6 @@ export const BrowserSessionGetSessionError = Schema.Union([
9393 BrowserSessionCreationError,
9494]);
9595export type BrowserSessionGetSessionError = typeof BrowserSessionGetSessionError.Type;
96export const isBrowserSessionGetSessionError = Schema.is(BrowserSessionGetSessionError);
9796
9897export const BrowserSessionError = Schema.Union([
9998 BrowserSessionPartitionDerivationError,
......@@ -102,7 +101,6 @@ export const BrowserSessionError = Schema.Union([
102101 BrowserSessionCacheClearError,
103102]);
104103export type BrowserSessionError = typeof BrowserSessionError.Type;
105export const isBrowserSessionError = Schema.is(BrowserSessionError);
106104
107105export class BrowserSession extends Context.Service<
108106 BrowserSession,
apps/desktop/src/updates/DesktopUpdates.test.ts-1
......@@ -794,7 +794,6 @@ describe("DesktopUpdates", () => {
794794 const error = yield* updates.setChannel("nightly").pipe(Effect.flip);
795795
796796 assert.instanceOf(error, DesktopUpdates.DesktopUpdateChannelPersistenceError);
797 assert.isTrue(DesktopUpdates.isDesktopUpdateSetChannelError(error));
798797 assert.equal(error.channel, "nightly");
799798 assert.strictEqual(error.cause, settingsFailure);
800799 assert.strictEqual(error.cause.cause, diskFailure);
apps/desktop/src/updates/DesktopUpdates.ts-1
......@@ -155,7 +155,6 @@ export const DesktopUpdateSetChannelError = Schema.Union([
155155 DesktopUpdateChannelPersistenceError,
156156]);
157157export type DesktopUpdateSetChannelError = typeof DesktopUpdateSetChannelError.Type;
158export const isDesktopUpdateSetChannelError = Schema.is(DesktopUpdateSetChannelError);
159158
160159export class DesktopUpdates extends Context.Service<
161160 DesktopUpdates,