authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 01:30:18-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 01:30:18-07:00
log56a2f42b8ce27f5deefaa85a02ae9c1d3b61f309
tree231bc9d2e3b139adb2be96a3fd2af36e9627f5a3
parent91ba05e870603b6bc0649e33973f73d86cbf58c3
signature Signed by PGP key B5690EEEBB952194

refactor(desktop): remove test-only error predicates (#10047)

8 files changed, 0 insertions(+), 18 deletions(-)

apps/desktop/src/backend/DesktopServerExposure.test.ts-3
...@@ -272,8 +272,6 @@ describe("DesktopServerExposure", () => {...@@ -272,8 +272,6 @@ describe("DesktopServerExposure", () => {
272 modeError,272 modeError,
273 DesktopServerExposure.DesktopServerExposureModePersistenceError,273 DesktopServerExposure.DesktopServerExposureModePersistenceError,
274 );274 );
275 assert.isTrue(DesktopServerExposure.isDesktopServerExposureSetModeError(modeError));
276 assert.isTrue(DesktopServerExposure.isDesktopServerExposureError(modeError));
277 assert.equal(modeError.mode, "network-accessible");275 assert.equal(modeError.mode, "network-accessible");
278 assert.strictEqual(modeError.cause, settingsFailure);276 assert.strictEqual(modeError.cause, settingsFailure);
279 assert.strictEqual(modeError.cause.cause, diskFailure);277 assert.strictEqual(modeError.cause.cause, diskFailure);
...@@ -290,7 +288,6 @@ describe("DesktopServerExposure", () => {...@@ -290,7 +288,6 @@ describe("DesktopServerExposure", () => {
290 tailscaleError,288 tailscaleError,
291 DesktopServerExposure.DesktopTailscaleServePersistenceError,289 DesktopServerExposure.DesktopTailscaleServePersistenceError,
292 );290 );
293 assert.isTrue(DesktopServerExposure.isDesktopServerExposureError(tailscaleError));
294 assert.equal(tailscaleError.enabled, true);291 assert.equal(tailscaleError.enabled, true);
295 assert.equal(tailscaleError.port, 8443);292 assert.equal(tailscaleError.port, 8443);
296 assert.strictEqual(tailscaleError.cause, settingsFailure);293 assert.strictEqual(tailscaleError.cause, settingsFailure);
apps/desktop/src/backend/DesktopServerExposure.ts-2
...@@ -244,7 +244,6 @@ export const DesktopServerExposureSetModeError = Schema.Union([...@@ -244,7 +244,6 @@ export const DesktopServerExposureSetModeError = Schema.Union([
244 DesktopServerExposureModePersistenceError,244 DesktopServerExposureModePersistenceError,
245]);245]);
246export type DesktopServerExposureSetModeError = typeof DesktopServerExposureSetModeError.Type;246export type DesktopServerExposureSetModeError = typeof DesktopServerExposureSetModeError.Type;
247export const isDesktopServerExposureSetModeError = Schema.is(DesktopServerExposureSetModeError);
248247
249export const DesktopServerExposureError = Schema.Union([248export const DesktopServerExposureError = Schema.Union([
250 DesktopServerExposureNoNetworkAddressError,249 DesktopServerExposureNoNetworkAddressError,
...@@ -252,7 +251,6 @@ export const DesktopServerExposureError = Schema.Union([...@@ -252,7 +251,6 @@ export const DesktopServerExposureError = Schema.Union([
252 DesktopTailscaleServePersistenceError,251 DesktopTailscaleServePersistenceError,
253]);252]);
254export type DesktopServerExposureError = typeof DesktopServerExposureError.Type;253export type DesktopServerExposureError = typeof DesktopServerExposureError.Type;
255export const isDesktopServerExposureError = Schema.is(DesktopServerExposureError);
256254
257export interface DesktopServerExposureBackendConfig {255export interface DesktopServerExposureBackendConfig {
258 readonly port: number;256 readonly port: number;
apps/desktop/src/ipc/DesktopIpc.test.ts-2
...@@ -41,7 +41,6 @@ describe("DesktopIpc", () => {...@@ -41,7 +41,6 @@ describe("DesktopIpc", () => {
41 const error = yield* Effect.flip(Effect.scoped(ipc.handle(invokeMethod)));41 const error = yield* Effect.flip(Effect.scoped(ipc.handle(invokeMethod)));
4242
43 assert.instanceOf(error, DesktopIpc.DesktopIpcRegistrationError);43 assert.instanceOf(error, DesktopIpc.DesktopIpcRegistrationError);
44 assert.isTrue(DesktopIpc.isDesktopIpcError(error));
45 assert.strictEqual(error.handlerKind, "invoke");44 assert.strictEqual(error.handlerKind, "invoke");
46 assert.strictEqual(error.channel, invokeMethod.channel);45 assert.strictEqual(error.channel, invokeMethod.channel);
47 assert.strictEqual(error.cause, cause);46 assert.strictEqual(error.cause, cause);
...@@ -69,7 +68,6 @@ describe("DesktopIpc", () => {...@@ -69,7 +68,6 @@ describe("DesktopIpc", () => {
69 if (exit._tag === "Success") return;68 if (exit._tag === "Success") return;
70 const error = Cause.squash(exit.cause);69 const error = Cause.squash(exit.cause);
71 assert.instanceOf(error, DesktopIpc.DesktopIpcUnregistrationError);70 assert.instanceOf(error, DesktopIpc.DesktopIpcUnregistrationError);
72 assert.isTrue(DesktopIpc.isDesktopIpcError(error));
73 assert.strictEqual(error.handlerKind, "sync");71 assert.strictEqual(error.handlerKind, "sync");
74 assert.strictEqual(error.channel, syncMethod.channel);72 assert.strictEqual(error.channel, syncMethod.channel);
75 assert.strictEqual(error.cause, cause);73 assert.strictEqual(error.cause, cause);
apps/desktop/src/ipc/DesktopIpc.ts-1
...@@ -55,7 +55,6 @@ export const DesktopIpcError = Schema.Union([...@@ -55,7 +55,6 @@ export const DesktopIpcError = Schema.Union([
55 DesktopIpcUnregistrationError,55 DesktopIpcUnregistrationError,
56]);56]);
57export type DesktopIpcError = typeof DesktopIpcError.Type;57export type DesktopIpcError = typeof DesktopIpcError.Type;
58export const isDesktopIpcError = Schema.is(DesktopIpcError);
5958
60export interface DesktopIpcMethod<E, R> {59export interface DesktopIpcMethod<E, R> {
61 readonly channel: string;60 readonly channel: string;
apps/desktop/src/preview/BrowserSession.test.ts-6
...@@ -172,8 +172,6 @@ describe("BrowserSession", () => {...@@ -172,8 +172,6 @@ describe("BrowserSession", () => {
172 const error = yield* browserSessions.getPartition("environment-a").pipe(Effect.flip);172 const error = yield* browserSessions.getPartition("environment-a").pipe(Effect.flip);
173173
174 assert.instanceOf(error, BrowserSession.BrowserSessionPartitionDerivationError);174 assert.instanceOf(error, BrowserSession.BrowserSessionPartitionDerivationError);
175 assert.isTrue(BrowserSession.isBrowserSessionGetSessionError(error));
176 assert.isTrue(BrowserSession.isBrowserSessionError(error));
177 assert.equal(error.scope, "environment-a");175 assert.equal(error.scope, "environment-a");
178 assert.strictEqual(error.cause, platformCause);176 assert.strictEqual(error.cause, platformCause);
179 assert.strictEqual(error.cause.reason.cause, nativeCause);177 assert.strictEqual(error.cause.reason.cause, nativeCause);
...@@ -196,8 +194,6 @@ describe("BrowserSession", () => {...@@ -196,8 +194,6 @@ describe("BrowserSession", () => {
196 const error = yield* browserSessions.getSession("environment-b").pipe(Effect.flip);194 const error = yield* browserSessions.getSession("environment-b").pipe(Effect.flip);
197195
198 assert.instanceOf(error, BrowserSession.BrowserSessionCreationError);196 assert.instanceOf(error, BrowserSession.BrowserSessionCreationError);
199 assert.isTrue(BrowserSession.isBrowserSessionGetSessionError(error));
200 assert.isTrue(BrowserSession.isBrowserSessionError(error));
201 assert.equal(error.scope, "environment-b");197 assert.equal(error.scope, "environment-b");
202 assert.equal(error.partition, partition);198 assert.equal(error.partition, partition);
203 assert.strictEqual(error.cause, cause);199 assert.strictEqual(error.cause, cause);
...@@ -270,7 +266,6 @@ describe("BrowserSession", () => {...@@ -270,7 +266,6 @@ describe("BrowserSession", () => {
270 const storageError = yield* browserSessions.clearCookies().pipe(Effect.flip);266 const storageError = yield* browserSessions.clearCookies().pipe(Effect.flip);
271267
272 assert.instanceOf(storageError, BrowserSession.BrowserSessionStorageClearError);268 assert.instanceOf(storageError, BrowserSession.BrowserSessionStorageClearError);
273 assert.isTrue(BrowserSession.isBrowserSessionError(storageError));
274 assert.equal(storageError.partition, secondPartition);269 assert.equal(storageError.partition, secondPartition);
275 assert.strictEqual(storageError.cause, storageCause);270 assert.strictEqual(storageError.cause, storageCause);
276 assert.equal(271 assert.equal(
...@@ -287,7 +282,6 @@ describe("BrowserSession", () => {...@@ -287,7 +282,6 @@ describe("BrowserSession", () => {
287 const cacheError = yield* browserSessions.clearCache().pipe(Effect.flip);282 const cacheError = yield* browserSessions.clearCache().pipe(Effect.flip);
288283
289 assert.instanceOf(cacheError, BrowserSession.BrowserSessionCacheClearError);284 assert.instanceOf(cacheError, BrowserSession.BrowserSessionCacheClearError);
290 assert.isTrue(BrowserSession.isBrowserSessionError(cacheError));
291 assert.equal(cacheError.partition, firstPartition);285 assert.equal(cacheError.partition, firstPartition);
292 assert.strictEqual(cacheError.cause, cacheCause);286 assert.strictEqual(cacheError.cause, cacheCause);
293 assert.equal(287 assert.equal(
apps/desktop/src/preview/BrowserSession.ts-2
...@@ -93,7 +93,6 @@ export const BrowserSessionGetSessionError = Schema.Union([...@@ -93,7 +93,6 @@ export const BrowserSessionGetSessionError = Schema.Union([
93 BrowserSessionCreationError,93 BrowserSessionCreationError,
94]);94]);
95export type BrowserSessionGetSessionError = typeof BrowserSessionGetSessionError.Type;95export type BrowserSessionGetSessionError = typeof BrowserSessionGetSessionError.Type;
96export const isBrowserSessionGetSessionError = Schema.is(BrowserSessionGetSessionError);
9796
98export const BrowserSessionError = Schema.Union([97export const BrowserSessionError = Schema.Union([
99 BrowserSessionPartitionDerivationError,98 BrowserSessionPartitionDerivationError,
...@@ -102,7 +101,6 @@ export const BrowserSessionError = Schema.Union([...@@ -102,7 +101,6 @@ export const BrowserSessionError = Schema.Union([
102 BrowserSessionCacheClearError,101 BrowserSessionCacheClearError,
103]);102]);
104export type BrowserSessionError = typeof BrowserSessionError.Type;103export type BrowserSessionError = typeof BrowserSessionError.Type;
105export const isBrowserSessionError = Schema.is(BrowserSessionError);
106104
107export class BrowserSession extends Context.Service<105export class BrowserSession extends Context.Service<
108 BrowserSession,106 BrowserSession,
apps/desktop/src/updates/DesktopUpdates.test.ts-1
...@@ -794,7 +794,6 @@ describe("DesktopUpdates", () => {...@@ -794,7 +794,6 @@ describe("DesktopUpdates", () => {
794 const error = yield* updates.setChannel("nightly").pipe(Effect.flip);794 const error = yield* updates.setChannel("nightly").pipe(Effect.flip);
795795
796 assert.instanceOf(error, DesktopUpdates.DesktopUpdateChannelPersistenceError);796 assert.instanceOf(error, DesktopUpdates.DesktopUpdateChannelPersistenceError);
797 assert.isTrue(DesktopUpdates.isDesktopUpdateSetChannelError(error));
798 assert.equal(error.channel, "nightly");797 assert.equal(error.channel, "nightly");
799 assert.strictEqual(error.cause, settingsFailure);798 assert.strictEqual(error.cause, settingsFailure);
800 assert.strictEqual(error.cause.cause, diskFailure);799 assert.strictEqual(error.cause.cause, diskFailure);
apps/desktop/src/updates/DesktopUpdates.ts-1
...@@ -155,7 +155,6 @@ export const DesktopUpdateSetChannelError = Schema.Union([...@@ -155,7 +155,6 @@ export const DesktopUpdateSetChannelError = Schema.Union([
155 DesktopUpdateChannelPersistenceError,155 DesktopUpdateChannelPersistenceError,
156]);156]);
157export type DesktopUpdateSetChannelError = typeof DesktopUpdateSetChannelError.Type;157export type DesktopUpdateSetChannelError = typeof DesktopUpdateSetChannelError.Type;
158export const isDesktopUpdateSetChannelError = Schema.is(DesktopUpdateSetChannelError);
159158
160export class DesktopUpdates extends Context.Service<159export class DesktopUpdates extends Context.Service<
161 DesktopUpdates,160 DesktopUpdates,