Commit 5a9b56291f82b9269346053594d8b5dfca736976 | the-knife

author	Abdul Azeez <abdulazeez44@gmail.com> 2026-09-03 02:54:24+05:30
committer	GitHub <noreply@github.com> 2026-09-02 17:24:24-04:00
log	5a9b56291f82b9269346053594d8b5dfca736976
tree	4121f4e473d8debdec13ae58385db3e6a99abb31
parent	46b5c66406b9942589d7e9132beeafda2434f113
signature	Signed by PGP key B5690EEEBB952194

1 files changed, 14 insertions(+), 7 deletions(-)

apps/web/src/hooks/useSettings.ts+14-7

 @@ -377,24 +377,31 @@ function useUpdateSettingsTarget(environmentId: EnvironmentId | null) {
       if (Object.keys(serverPatch).length > 0) {
         const { sharedPatch, localPatch } = splitSharedServerPatch(serverPatch);
-        if (environmentId && Object.keys(localPatch).length > 0) {
+        // Dropping the write silently leaves the control looking saved.
-          void persistServerSettings({
+        const warnUnsaved = () =>
-            environmentId,
-            input: { patch: localPatch },
-          });
-        } else {
-          // Dropping the write silently leaves the control looking saved.
           toastManager.add({
             type: "warning",
             title: "Setting not saved",
             description: PRIMARY_SETTINGS_UNAVAILABLE_MESSAGE,
           });
+        if (Object.keys(localPatch).length > 0) {
+          if (environmentId) {
+            void persistServerSettings({
+              environmentId,
+              input: { patch: localPatch },
+            });
+          } else {
+            warnUnsaved();
+          }
         }
         if (Object.keys(sharedPatch).length > 0) {
           const targets = new Set(connectedEnvironmentIds);
           if (environmentId) {
             targets.add(environmentId);
           }
+          if (targets.size === 0) {
+            warnUnsaved();
+          }
           for (const targetId of targets) {
             void persistServerSettings({
               environmentId: targetId,