Commit 617edab6539ee6573055dc9fc45fdeacdb12f673 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-09-03 19:07:24-07:00
committer	GitHub <noreply@github.com> 2026-09-03 19:07:24-07:00
log	617edab6539ee6573055dc9fc45fdeacdb12f673
tree	22c7b05c4ff9aa081990619c467f5d23675dc81b
parent	3e2c1a66f74f0a45768332c360cd3682f61129e1
signature	Signed by PGP key B5690EEEBB952194

fix(server): reveal normalized paths in File Explorer (#9551)

2 files changed, 19 insertions(+), 5 deletions(-)

apps
- server
  - src
    process
    externalLauncher.test.ts
    externalLauncher.ts

apps/server/src/process/externalLauncher.test.ts+10-4

 @@ -206,7 +206,9 @@ it.effect("reveals a file in File Explorer through PowerShell on Windows", () =>
       const launcher = yield* ExternalLauncher.ExternalLauncher;
       yield* launcher.launchEditor({
         editor: "file-manager",
-        cwd: "C:\\workspace with spaces\\media\\author's clip.mp4",
+        // Web file links normalize separators even when the server runs on
+        // Windows. Explorer's `/select` switch requires Windows separators.
+        cwd: "C:/workspace with spaces/media/author's clip.mp4",
         reveal: true,
       });
       return yield* launcher.resolveFileManagerRevealKind();
 @@ -261,8 +263,12 @@ it.skipIf(process.platform !== "win32")(
       const outputPath = NodePath.join(tempDir, "argv.txt");
       NodeFS.writeFileSync(recorderPath, `@echo off\r\n>"${outputPath}" echo(%*\r\n`);
-      const target = "C:\\workspace with spaces\\media\\author's clip.mp4";
+      const target = "C:/workspace with spaces/media/author's clip.mp4";
-      const source = ExternalLauncher.buildFileExplorerRevealPowerShellSource(recorderPath, target);
+      const explorerTarget = target.replaceAll("/", "\\");
+      const source = ExternalLauncher.buildFileExplorerRevealPowerShellSource(
+        recorderPath,
+        explorerTarget,
+      );
       const powerShellPath = `${process.env.SYSTEMROOT ?? "C:\\Windows"}\\System32\\WindowsPowerShell\\v1.0\\powershell.exe`;
       NodeChildProcess.execFileSync(
         powerShellPath,
 @@ -290,7 +296,7 @@ it.skipIf(process.platform !== "win32")(
       }
       await sleep(200);
       const recorded = NodeFS.readFileSync(outputPath, "utf8").trim();
-      assert.equal(recorded, `/select,"${target}"`);
+      assert.equal(recorded, `/select,"${explorerTarget}"`);
     } finally {
       NodeFS.rmSync(tempDir, { recursive: true, force: true });
     }

apps/server/src/process/externalLauncher.ts+9-1

 @@ -609,6 +609,10 @@ function fileExplorerRevealLaunch(
   };
 }
+function normalizeWindowsFileManagerPath(target: string): string {
+  return target.replaceAll("/", "\\");
+}
 const resolveFileManagerRevealLaunch = Effect.fn("resolveFileManagerRevealLaunch")(function* (
   target: string,
   platform: NodeJS.Platform,
 @@ -626,7 +630,11 @@ const resolveFileManagerRevealLaunch = Effect.fn("resolveFileManagerRevealLaunch
   }
   if (platform === "win32") {
-    return fileExplorerRevealLaunch(target, target, resolvePowerShellPath(env));
+    return fileExplorerRevealLaunch(
+      target,
+      normalizeWindowsFileManagerPath(target),
+      resolvePowerShellPath(env),
+    );
   }
   if (