Commit 6cf03d987c28af7fdc7867d63f791720a0464a27 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-26 08:47:29-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-26 13:20:36-08:00
log	6cf03d987c28af7fdc7867d63f791720a0464a27
tree	1bad2b8dd6cfbf97e189ff517fca695eadcb8ac5
parent	9b8184df7e1a5fd1837b21eaa225d06f614b574b

cleanup

2 files changed, 9 insertions(+), 11 deletions(-)

.plans
- 16c-pr89-remediation-checklist.md
apps
- server
  - src
    config.ts

.plans/16c-pr89-remediation-checklist.md+2-11

 @@ -333,15 +333,6 @@ Counts: active `51` (`valid=33`, `partially-valid=18`), closed-invalid `6`
 ### Phase 6
-- [ ] `C024` In `executeUnprepared`, preparing outside an effect and not closing the statement can cause uncaught errors and leaks. Suggest wrapping with `Effect.acquireUseRelease`: prepare in acquire (error-safe) and `finalize` in release.
-  - Status: `TODO`
-  - Verdict: `partially-valid`
-  - Severity: `Medium`
-  - Area: `Other`
-  - File: `apps/server/src/persistence/NodeSqliteClient.ts:145`
-  - Threads: PRRT_kwDORLtfbc5whxX9
-  - Audit note: prepare() still outside managed effect boundary; failure handling risk remains.
 - [ ] `C028` Branch sync dispatches both server and stale local update
   - Status: `TODO`
   - Verdict: `partially-valid`
 @@ -351,8 +342,8 @@ Counts: active `51` (`valid=33`, `partially-valid=18`), closed-invalid `6`
   - Threads: PRRT_kwDORLtfbc5v-XCu
   - Audit note: Optimistic local+server dual update is intentional but can temporarily diverge.
-- [ ] `C037` `Effect.callback` should return a cleanup function to close the server(s) on fiber interruption. Without it, the `Net.Server` handles keep the process alive and leak the port if the effect is cancelled. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary>
+- [x] `C037` `Effect.callback` should return a cleanup function to close the server(s) on fiber interruption. Without it, the `Net.Server` handles keep the process alive and leak the port if the effect is cancelled. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary>
-  - Status: `TODO`
+  - Status: `DONE`
   - Verdict: `partially-valid`
   - Severity: `Low`
   - Area: `Other`

apps/server/src/config.ts+7

 @@ -66,6 +66,7 @@ export class NetService extends ServiceMap.Service<NetService, NetServiceShape>(
   static readonly layer = Layer.succeed(NetService, {
     findAvailablePort: (preferred) =>
       Effect.callback<number, NetError>((resume) => {
+        let fallbackServer: Net.Server | null = null;
         const server = Net.createServer();
         server.listen(preferred, () => {
           server.close(() => resume(Effect.succeed(preferred)));
 @@ -88,6 +89,12 @@ export class NetService extends ServiceMap.Service<NetService, NetServiceShape>(
               Effect.fail(new NetError({ message: "Failed to find an available port", cause })),
             );
           });
+          fallbackServer = fallback;
+        });
+        return Effect.sync(() => {
+          server.close();
+          fallbackServer?.close();
         });
       }),
   });