Commit 6f92f0a66855ef6745814b0a91cffc2d588e0777 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-27 20:48:48-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-27 21:30:46-08:00
log	6f92f0a66855ef6745814b0a91cffc2d588e0777
tree	4401cddfa575cdc34f5baaaa7785229bb11d13b9
parent	35817601ff3f3d4f2e27ea8c5c8a08a8b0926dc3

kewl

2 files changed, 21 insertions(+), 29 deletions(-)

apps
- server
  - src
    orchestration
    Layers
    ProjectionPipeline.ts
    wsServer.ts

apps/server/src/orchestration/Layers/ProjectionPipeline.ts+20-26

 @@ -1,3 +1,4 @@
+import Mime from "@effect/platform-node/Mime";
 import {
   ApprovalRequestId,
   type ChatAttachment,
 @@ -112,20 +113,13 @@ function parseBase64DataUrl(
 }
 function inferImageExtension(attachment: Extract<ChatAttachment, { type: "image" }>): string {
-  const normalizedMimeType = attachment.mimeType.trim().toLowerCase();
+  const normalizedMimeType = attachment.mimeType.toLowerCase();
   if (normalizedMimeType.startsWith("image/")) {
     const fromMime = IMAGE_EXTENSION_BY_MIME_TYPE[normalizedMimeType];
-    if (fromMime) {
+    if (fromMime) return fromMime;
-      return fromMime;
-    }
-  }
-  const fromName = attachment.name.includes(".")
-    ? `.${attachment.name.split(".").slice(-1)[0]?.toLowerCase() ?? ""}`
-    : "";
-  if (/^\.[a-z0-9]{1,12}$/.test(fromName) && SAFE_IMAGE_FILE_EXTENSIONS.has(fromName)) {
-    return fromName;
   }
+  const ext = Mime.getExtension(attachment.mimeType);
+  if (ext && SAFE_IMAGE_FILE_EXTENSIONS.has(ext)) return ext;
   return ".bin";
 }
 @@ -135,14 +129,10 @@ const materializeAttachmentsForProjection = Effect.fn(function* (input: {
   readonly attachments: ReadonlyArray<ChatAttachment>;
   readonly stageFileWrite: (pendingWrite: PendingAttachmentWrite) => void;
 }) {
-  if (input.attachments.length === 0) {
+  if (input.attachments.length === 0) return [];
-    return [] as ReadonlyArray<ChatAttachment>;
-  }
   const serverConfig = yield* Effect.serviceOption(ServerConfig);
-  if (Option.isNone(serverConfig)) {
+  if (Option.isNone(serverConfig)) return input.attachments;
-    return input.attachments;
-  }
   const path = yield* Path.Path;
   const attachmentsRootDir = path.join(serverConfig.value.stateDir, ATTACHMENTS_STATE_SUBDIRECTORY);
 @@ -166,9 +156,7 @@ const materializeAttachmentsForProjection = Effect.fn(function* (input: {
         }
         const bytes = Buffer.from(parsed.base64, "base64");
-        if (bytes.byteLength === 0) {
+        if (bytes.byteLength === 0) return attachment;
-          return attachment;
-        }
         const fileName = `${index}${inferImageExtension({
           ...attachment,
 @@ -375,9 +363,7 @@ const runAttachmentSideEffects = Effect.fn(function* (input: {
           entries,
           (entry) =>
             Effect.gen(function* () {
-              const threadRelativePath = entry
+              const threadRelativePath = entry.replace(/^[/\\]+/, "").replace(/\\/g, "/");
-                .replace(/^[/\\]+/, "")
-                .replace(/\\/g, "/");
               if (threadRelativePath.length === 0 || threadRelativePath.startsWith("..")) {
                 return;
               }
 @@ -411,7 +397,9 @@ const runAttachmentSideEffects = Effect.fn(function* (input: {
     writesByPath.entries(),
     ([absolutePath, bytes]) =>
       Effect.gen(function* () {
-        yield* input.fileSystem.makeDirectory(input.path.dirname(absolutePath), { recursive: true });
+        yield* input.fileSystem.makeDirectory(input.path.dirname(absolutePath), {
+          recursive: true,
+        });
         const alreadyExists = yield* input.fileSystem
           .exists(absolutePath)
           .pipe(Effect.catch(() => Effect.succeed(false)));
 @@ -615,7 +603,10 @@ const makeOrchestrationProjectionPipeline = Effect.gen(function* () {
       }
     });
-  const applyThreadMessagesProjection: ProjectorDefinition["apply"] = (event, attachmentSideEffects) =>
+  const applyThreadMessagesProjection: ProjectorDefinition["apply"] = (
+    event,
+    attachmentSideEffects,
+  ) =>
     Effect.gen(function* () {
       switch (event.type) {
         case "thread.message-sent": {
 @@ -778,7 +769,10 @@ const makeOrchestrationProjectionPipeline = Effect.gen(function* () {
       });
     });
-  const applyThreadTurnsProjection: ProjectorDefinition["apply"] = (event, _attachmentSideEffects) =>
+  const applyThreadTurnsProjection: ProjectorDefinition["apply"] = (
+    event,
+    _attachmentSideEffects,
+  ) =>
     Effect.gen(function* () {
       switch (event.type) {
         case "thread.turn-start-requested": {

apps/server/src/wsServer.ts+1-3

 @@ -330,9 +330,7 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
         const staticRequestPath = url.pathname === "/" ? "/index.html" : url.pathname;
         const rawStaticRelativePath = staticRequestPath.replace(/^[/\\]+/, "");
         const hasRawLeadingParentSegment = rawStaticRelativePath.startsWith("..");
-        const staticRelativePath = path
+        const staticRelativePath = path.normalize(rawStaticRelativePath).replace(/^[/\\]+/, "");
-          .normalize(rawStaticRelativePath)
-          .replace(/^[/\\]+/, "");
         const hasPathTraversalSegment = staticRelativePath.startsWith("..");
         if (
           staticRelativePath.length === 0 ||