Commit 70f5dfcef78a8e153ab698c0b83661974a4fc033 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-04-09 14:26:28-07:00
committer	GitHub <noreply@github.com> 2026-04-09 14:26:28-07:00
log	70f5dfcef78a8e153ab698c0b83661974a4fc033
tree	a0b7a282eab3757e3ada68d80b18e92241c9cbe1
parent	9847e9b6211df61bd6d3d1142538ec4df77e0013
signature	Signed by PGP key B5690EEEBB952194

Stabilize keybindings toast stream setup (#1860)

Co-authored-by: Julius Marminge <julius@macmini.local>

1 files changed, 29 insertions(+), 8 deletions(-)

apps
- web
  - src
    components
    KeybindingsToast.browser.tsx

apps/web/src/components/KeybindingsToast.browser.tsx+29-8

 @@ -21,7 +21,7 @@ import { render } from "vitest-browser-react";
 import { useComposerDraftStore } from "../composerDraftStore";
 import { __resetLocalApiForTests } from "../localApi";
 import { AppAtomRegistryProvider } from "../rpc/atomRegistry";
-import { getServerConfig } from "../rpc/serverState";
+import { getServerConfig, getServerConfigUpdatedNotification } from "../rpc/serverState";
 import { getWsConnectionStatus } from "../rpc/wsConnectionState";
 import { getRouter } from "../router";
 import { useStore } from "../store";
 @@ -303,11 +303,6 @@ async function waitForNoToasts(): Promise<void> {
   );
 }
-async function warmServerConfigUpdateStream(): Promise<void> {
-  sendServerConfigUpdatedPush([]);
-  await new Promise((resolve) => setTimeout(resolve, 50));
-}
 async function waitForInitialWsSubscriptions(): Promise<void> {
   await vi.waitFor(
     () => {
 @@ -331,6 +326,33 @@ async function waitForServerConfigSnapshot(): Promise<void> {
   );
 }
+async function waitForServerConfigStreamReady(): Promise<void> {
+  const previousNotificationId = getServerConfigUpdatedNotification()?.id ?? 0;
+  for (let attempt = 0; attempt < 20; attempt += 1) {
+    rpcHarness.emitStreamValue(WS_METHODS.subscribeServerConfig, {
+      version: 1,
+      type: "settingsUpdated",
+      payload: { settings: fixture.serverConfig.settings },
+    });
+    try {
+      await vi.waitFor(
+        () => {
+          const notification = getServerConfigUpdatedNotification();
+          expect(notification?.id).toBeGreaterThan(previousNotificationId);
+          expect(notification?.source).toBe("settingsUpdated");
+        },
+        { timeout: 200, interval: 16 },
+      );
+      return;
+    } catch {
+      await new Promise((resolve) => setTimeout(resolve, 25));
+    }
+  }
+  throw new Error("Timed out waiting for the server config stream to deliver updates.");
+}
 async function mountApp(): Promise<{ cleanup: () => Promise<void> }> {
   const host = document.createElement("div");
   host.style.position = "fixed";
 @@ -356,6 +378,7 @@ async function mountApp(): Promise<{ cleanup: () => Promise<void> }> {
   await waitForInitialWsSubscriptions();
   await waitForWsConnection();
   await waitForServerConfigSnapshot();
+  await waitForServerConfigStreamReady();
   await waitForNoToasts();
   return {
 @@ -429,8 +452,6 @@ describe("Keybindings update toast", () => {
     const mounted = await mountApp();
     try {
-      await warmServerConfigUpdateStream();
       sendServerConfigUpdatedPush([]);
       await waitForToast("Keybindings updated", 1);