authorgravatar for maria@kuuro.netmaria <maria@kuuro.net> 2026-08-30 20:39:51-04:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-08-30 20:39:51-04:00
log8b817cbcaad71a53e2ef73f3881067f8aa8094bc
tree2d177186e475a953916a9beec5c7006436090ab3
parent17c48f7fc1af66110706b013bf41901ebcd8aedb
signature Signed by PGP key B5690EEEBB952194

fix(web): use circle alert for failed tool calls (#8840)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

2 files changed, 4 insertions(+), 4 deletions(-)

apps/web/src/components/chat/MessagesTimeline.test.tsx+2-2
......@@ -1473,7 +1473,7 @@ describe("MessagesTimeline", () => {
14731473 />,
14741474 );
14751475
1476 expect(markup).toContain("lucide-x");
1476 expect(markup).toContain("lucide-circle-alert");
14771477 expect(markup).toContain('aria-label="Tool call failed"');
14781478 // Ordinary tool failures render muted, not red.
14791479 expect(markup).not.toContain("text-destructive");
......@@ -1511,7 +1511,7 @@ describe("MessagesTimeline", () => {
15111511 />,
15121512 );
15131513
1514 expect(markup).toContain("lucide-x");
1514 expect(markup).toContain("lucide-circle-alert");
15151515 expect(markup).toContain("text-destructive");
15161516 });
15171517});
apps/web/src/components/chat/MessagesTimeline.tsx+2-2
......@@ -1579,7 +1579,7 @@ function LiveActivityContent({
15791579 announceFailure?: boolean;
15801580 highlighted?: boolean;
15811581}) {
1582 const resolvedIconName = failed ? "x" : iconName;
1582 const resolvedIconName = failed ? "circle-alert" : iconName;
15831583
15841584 return (
15851585 <div
......@@ -2554,7 +2554,7 @@ const PlainWorkEntryRow = memo(function PlainWorkEntryRow(props: {
25542554 const showWarningIndicator = workEntry.sourceActivityKind === "runtime.warning";
25552555 const showFailedIndicator = workEntryDisplayIndicatesToolFailure(workEntry);
25562556 const entryIconName =
2557 showWarningIndicator || showFailedIndicator ? "x" : workEntryIconName(workEntry);
2557 showWarningIndicator || showFailedIndicator ? "circle-alert" : workEntryIconName(workEntry);
25582558 const displayText = workEntryPreview(workEntry, workspaceRoot) ?? toolWorkEntryHeading(workEntry);
25592559 const expandedBody = buildToolCallExpandedBody(workEntry, workspaceRoot);
25602560 const canExpand = expandedBody !== null;