Commit 901579233cf0c846abcd9622f1443db6d3bb5834 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-12 21:17:11-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-12 22:20:01-08:00
log	901579233cf0c846abcd9622f1443db6d3bb5834
tree	8c3e04ec01a2476b890ff962826f92571eb884d4
parent	d27b08bae68ac514f5f3a497bc4aa91c0cbfc101

Close terminal session when hiding terminal panel

- Attempt `api.terminal.close` when toggling an open terminal off
- Fall back to sending `exit` if close is unavailable or fails
- Include `api` in callback dependencies to keep behavior current

1 files changed, 16 insertions(+), 13 deletions(-)

apps
- web
  - src
    components
    ChatView.tsx

apps/web/src/components/ChatView.tsx+16-13

 @@ -263,12 +263,23 @@ export default function ChatView() {
   const toggleTerminalVisibility = useCallback(() => {
     if (!activeThreadId) return;
     const isOpen = Boolean(activeThread?.terminalOpen);
+    if (isOpen && api) {
+      if (typeof api.terminal.close === "function") {
+        void api.terminal.close({ threadId: activeThreadId }).catch(() => {
+          void api.terminal.write({ threadId: activeThreadId, data: "exit\n" }).catch(() => undefined);
+        });
+      } else {
+        void api.terminal.write({ threadId: activeThreadId, data: "exit\n" }).catch(() => undefined);
+      }
+    }
     dispatch({
       type: "SET_THREAD_TERMINAL_OPEN",
       threadId: activeThreadId,
       open: !isOpen,
     });
-  }, [activeThread?.terminalOpen, activeThreadId, dispatch]);
+  }, [activeThread?.terminalOpen, activeThreadId, api, dispatch]);
   const splitTerminal = useCallback(() => {
     if (!activeThreadId) return;
     dispatch({
 @@ -303,21 +314,13 @@ export default function ChatView() {
     (terminalId: string) => {
       if (!activeThreadId || !api) return;
       const fallbackExitWrite = () =>
-        api.terminal
+        api.terminal.write({ threadId: activeThreadId, terminalId, data: "exit\n" }).catch(() => undefined);
-          .write({ threadId: activeThreadId, terminalId, data: "exit\n" })
-          .catch(() => undefined);
-      const fallbackClearAndExit = () =>
-        api.terminal
-          .clear({ threadId: activeThreadId, terminalId })
-          .catch(() => undefined)
-          .then(() => fallbackExitWrite())
-          .catch(() => undefined);
       if ("close" in api.terminal && typeof api.terminal.close === "function") {
         void api.terminal
-          .close({ threadId: activeThreadId, terminalId, deleteHistory: true })
+          .close({ threadId: activeThreadId, terminalId })
-          .catch(() => fallbackClearAndExit());
+          .catch(() => fallbackExitWrite());
       } else {
-        void fallbackClearAndExit();
+        void fallbackExitWrite();
       }
       dispatch({
         type: "CLOSE_THREAD_TERMINAL",