authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:29:32-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:29:32-07:00
log93d4dfa2064dc4a598a3e66543c3b90ffb138609
tree7ddab50fd7946f6f637b3b53613e73baddb5747a
parent270e021f2a7ed34e3d81d1cdc9f1ca0c0ac85df4
signature Signed by PGP key B5690EEEBB952194

refactor(web): remove unused desktop update visibility helper (#10014)

2 files changed, 1 insertions(+), 18 deletions(-)

apps/web/src/components/desktopUpdate.logic.test.ts+1-8
......@@ -12,7 +12,6 @@ import {
1212 isDesktopUpdateButtonDisabled,
1313 resolveDesktopUpdateButtonAction,
1414 shouldShowArm64IntelBuildWarning,
15 shouldShowDesktopUpdateButton,
1615 shouldToastDesktopUpdateActionResult,
1716} from "./desktopUpdate.logic";
1817
......@@ -42,7 +41,6 @@ describe("desktop update button state", () => {
4241 status: "available",
4342 availableVersion: "1.1.0",
4443 };
45 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
4644 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");
4745 });
4846
......@@ -55,7 +53,6 @@ describe("desktop update button state", () => {
5553 errorContext: "download",
5654 canRetry: true,
5755 };
58 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
5956 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");
6057 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");
6158 });
......@@ -70,7 +67,6 @@ describe("desktop update button state", () => {
7067 errorContext: "install",
7168 canRetry: true,
7269 };
73 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
7470 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");
7571 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");
7672 });
......@@ -85,7 +81,6 @@ describe("desktop update button state", () => {
8581 errorContext: null,
8682 canRetry: true,
8783 };
88 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
8984 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");
9085 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to restart and install");
9186 });
......@@ -111,7 +106,7 @@ describe("desktop update button state", () => {
111106 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");
112107 });
113108
114 it("hides the button for non-actionable check errors", () => {
109 it("has no action for non-actionable check errors", () => {
115110 const state: DesktopUpdateState = {
116111 ...baseState,
117112 status: "error",
......@@ -119,7 +114,6 @@ describe("desktop update button state", () => {
119114 errorContext: "check",
120115 canRetry: true,
121116 };
122 expect(shouldShowDesktopUpdateButton(state)).toBe(false);
123117 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");
124118 });
125119
......@@ -130,7 +124,6 @@ describe("desktop update button state", () => {
130124 availableVersion: "1.1.0",
131125 downloadPercent: 42.5,
132126 };
133 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
134127 expect(isDesktopUpdateButtonDisabled(state)).toBe(true);
135128 expect(getDesktopUpdateButtonTooltip(state)).toContain("42%");
136129 });
apps/web/src/components/desktopUpdate.logic.ts-10
......@@ -47,16 +47,6 @@ export function resolveDesktopUpdateButtonAction(
4747 return "none";
4848}
4949
50export function shouldShowDesktopUpdateButton(state: DesktopUpdateState | null): boolean {
51 if (!state || !state.enabled) {
52 return false;
53 }
54 if (state.status === "downloading") {
55 return true;
56 }
57 return resolveDesktopUpdateButtonAction(state) !== "none";
58}
59
6050export function shouldShowArm64IntelBuildWarning(state: DesktopUpdateState | null): boolean {
6151 return state?.hostArch === "arm64" && state.appArch === "x64";
6252}