authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:29:32-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:29:32-07:00
log93d4dfa2064dc4a598a3e66543c3b90ffb138609
tree7ddab50fd7946f6f637b3b53613e73baddb5747a
parent270e021f2a7ed34e3d81d1cdc9f1ca0c0ac85df4
signature Signed by PGP key B5690EEEBB952194

refactor(web): remove unused desktop update visibility helper (#10014)

2 files changed, 1 insertions(+), 18 deletions(-)

apps/web/src/components/desktopUpdate.logic.test.ts+1-8
...@@ -12,7 +12,6 @@ import {...@@ -12,7 +12,6 @@ import {
12 isDesktopUpdateButtonDisabled,12 isDesktopUpdateButtonDisabled,
13 resolveDesktopUpdateButtonAction,13 resolveDesktopUpdateButtonAction,
14 shouldShowArm64IntelBuildWarning,14 shouldShowArm64IntelBuildWarning,
15 shouldShowDesktopUpdateButton,
16 shouldToastDesktopUpdateActionResult,15 shouldToastDesktopUpdateActionResult,
17} from "./desktopUpdate.logic";16} from "./desktopUpdate.logic";
1817
...@@ -42,7 +41,6 @@ describe("desktop update button state", () => {...@@ -42,7 +41,6 @@ describe("desktop update button state", () => {
42 status: "available",41 status: "available",
43 availableVersion: "1.1.0",42 availableVersion: "1.1.0",
44 };43 };
45 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
46 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");44 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");
47 });45 });
4846
...@@ -55,7 +53,6 @@ describe("desktop update button state", () => {...@@ -55,7 +53,6 @@ describe("desktop update button state", () => {
55 errorContext: "download",53 errorContext: "download",
56 canRetry: true,54 canRetry: true,
57 };55 };
58 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
59 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");56 expect(resolveDesktopUpdateButtonAction(state)).toBe("download");
60 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");57 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");
61 });58 });
...@@ -70,7 +67,6 @@ describe("desktop update button state", () => {...@@ -70,7 +67,6 @@ describe("desktop update button state", () => {
70 errorContext: "install",67 errorContext: "install",
71 canRetry: true,68 canRetry: true,
72 };69 };
73 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
74 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");70 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");
75 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");71 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to retry");
76 });72 });
...@@ -85,7 +81,6 @@ describe("desktop update button state", () => {...@@ -85,7 +81,6 @@ describe("desktop update button state", () => {
85 errorContext: null,81 errorContext: null,
86 canRetry: true,82 canRetry: true,
87 };83 };
88 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
89 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");84 expect(resolveDesktopUpdateButtonAction(state)).toBe("install");
90 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to restart and install");85 expect(getDesktopUpdateButtonTooltip(state)).toContain("Click to restart and install");
91 });86 });
...@@ -111,7 +106,7 @@ describe("desktop update button state", () => {...@@ -111,7 +106,7 @@ describe("desktop update button state", () => {
111 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");106 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");
112 });107 });
113108
114 it("hides the button for non-actionable check errors", () => {109 it("has no action for non-actionable check errors", () => {
115 const state: DesktopUpdateState = {110 const state: DesktopUpdateState = {
116 ...baseState,111 ...baseState,
117 status: "error",112 status: "error",
...@@ -119,7 +114,6 @@ describe("desktop update button state", () => {...@@ -119,7 +114,6 @@ describe("desktop update button state", () => {
119 errorContext: "check",114 errorContext: "check",
120 canRetry: true,115 canRetry: true,
121 };116 };
122 expect(shouldShowDesktopUpdateButton(state)).toBe(false);
123 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");117 expect(resolveDesktopUpdateButtonAction(state)).toBe("none");
124 });118 });
125119
...@@ -130,7 +124,6 @@ describe("desktop update button state", () => {...@@ -130,7 +124,6 @@ describe("desktop update button state", () => {
130 availableVersion: "1.1.0",124 availableVersion: "1.1.0",
131 downloadPercent: 42.5,125 downloadPercent: 42.5,
132 };126 };
133 expect(shouldShowDesktopUpdateButton(state)).toBe(true);
134 expect(isDesktopUpdateButtonDisabled(state)).toBe(true);127 expect(isDesktopUpdateButtonDisabled(state)).toBe(true);
135 expect(getDesktopUpdateButtonTooltip(state)).toContain("42%");128 expect(getDesktopUpdateButtonTooltip(state)).toContain("42%");
136 });129 });
apps/web/src/components/desktopUpdate.logic.ts-10
...@@ -47,16 +47,6 @@ export function resolveDesktopUpdateButtonAction(...@@ -47,16 +47,6 @@ export function resolveDesktopUpdateButtonAction(
47 return "none";47 return "none";
48}48}
4949
50export function shouldShowDesktopUpdateButton(state: DesktopUpdateState | null): boolean {
51 if (!state || !state.enabled) {
52 return false;
53 }
54 if (state.status === "downloading") {
55 return true;
56 }
57 return resolveDesktopUpdateButtonAction(state) !== "none";
58}
59
60export function shouldShowArm64IntelBuildWarning(state: DesktopUpdateState | null): boolean {50export function shouldShowArm64IntelBuildWarning(state: DesktopUpdateState | null): boolean {
61 return state?.hostArch === "arm64" && state.appArch === "x64";51 return state?.hostArch === "arm64" && state.appArch === "x64";
62}52}