authorgravatar for stark.burns@adexpartners.comAdEx-Partners-DE <stark.burns@adexpartners.com> 2026-10-12 10:10:43+02:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-10-12 05:10:43-03:00
loga27cf8af51ec6a369dcd25c1c1f3ef520e22894d
tree4392dde6a9ed7ab53d1b444c0f63b6372d710d9d
parentb3871d5156f6c4160ea2afd96f65e34bf15ef91d
signature Signed by PGP key B5690EEEBB952194

test(provider-acp): terminal kill test passes on Windows hosts (#18450)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1 files changed, 7 insertions(+), 1 deletions(-)

packages/provider-acp/src/server/clientTerminals.test.ts+7-1
......@@ -2,6 +2,7 @@ import * as NodeServices from "@effect/platform-node/NodeServices";
22import { describe, expect, it } from "@effect/vitest";
33import * as Effect from "effect/Effect";
44import * as Result from "effect/Result";
5import * as HostProcess from "@t3tools/shared/HostProcess";
56
67import {
78 makeAcpClientTerminals,
......@@ -126,7 +127,12 @@ describe("AcpClientTerminals", () => {
126127 terminalId: created.terminalId,
127128 });
128129 expect(exit.exitCode === 0 ? null : exit.exitCode).not.toBe(0);
129 expect(exit.signal).toBe("SIGTERM");
130 // Windows has no signals: a killed process only reports an exit code.
131 if (yield* HostProcess.isWindows) {
132 expect(exit.signal).toBeNull();
133 } else {
134 expect(exit.signal).toBe("SIGTERM");
135 }
130136
131137 yield* terminals.release({ sessionId: "session", terminalId: created.terminalId });
132138 const rejected = yield* Effect.flip(