| author |  Julius Marminge <julius0216@outlook.com> 2026-09-05 00:19:37-07:00 |
| committer |  GitHub <noreply@github.com> 2026-09-05 00:19:37-07:00 |
| log | c7e93f520bbd1ba4b795a5fb1aad14778aa1d047 |
| tree | cae7df563493bc9ee3f3b607fad845c68d09892e |
| parent | 487d1766caba52579f07a3e5ebc6f276227e4382 |
| signature | Signed by PGP key B5690EEEBB952194 |
refactor(web): remove unused aspect ratio reconciler (#9994)
2 files changed, 1 insertions(+), 19 deletions(-)
apps
apps/web/src/browser/BrowserDeviceToolbar.test.ts+1-12
| ... | @@ -1,10 +1,7 @@ | ... | @@ -1,10 +1,7 @@ |
| 1 | import type { PreviewViewportSetting } from "@t3tools/contracts"; | 1 | import type { PreviewViewportSetting } from "@t3tools/contracts"; |
| 2 | import { describe, expect, it, vi } from "vite-plus/test"; | 2 | import { describe, expect, it, vi } from "vite-plus/test"; |
| 3 | 3 | ||
| 4 | import { | 4 | import { commitViewportAndAspectRatio } from "./browserDeviceToolbarState"; |
| 5 | commitViewportAndAspectRatio, | ||
| 6 | reconcileLockedAspectRatio, | ||
| 7 | } from "./browserDeviceToolbarState"; | ||
| 8 | 5 | ||
| 9 | describe("commitViewportAndAspectRatio", () => { | 6 | describe("commitViewportAndAspectRatio", () => { |
| 10 | it("commits the aspect ratio only after the viewport succeeds", async () => { | 7 | it("commits the aspect ratio only after the viewport succeeds", async () => { |
| ... | @@ -39,11 +36,3 @@ describe("commitViewportAndAspectRatio", () => { | ... | @@ -39,11 +36,3 @@ describe("commitViewportAndAspectRatio", () => { |
| 39 | expect(onAspectRatioChange).not.toHaveBeenCalled(); | 36 | expect(onAspectRatioChange).not.toHaveBeenCalled(); |
| 40 | }); | 37 | }); |
| 41 | }); | 38 | }); |
| 42 | |||
| 43 | describe("reconcileLockedAspectRatio", () => { | ||
| 44 | it("tracks external viewport ratios only while the lock remains active", () => { | ||
| 45 | expect(reconcileLockedAspectRatio(1.5, 16 / 9)).toBe(16 / 9); | ||
| 46 | expect(reconcileLockedAspectRatio(null, 16 / 9)).toBeNull(); | ||
| 47 | expect(reconcileLockedAspectRatio(1.5, null)).toBeNull(); | ||
| 48 | }); | ||
| 49 | }); |
apps/web/src/browser/browserDeviceToolbarState.ts-7
| ... | @@ -1,12 +1,5 @@ | ... | @@ -1,12 +1,5 @@ |
| 1 | import type { PreviewViewportSetting } from "@t3tools/contracts"; | 1 | import type { PreviewViewportSetting } from "@t3tools/contracts"; |
| 2 | 2 | ||
| 3 | export function reconcileLockedAspectRatio( | ||
| 4 | current: number | null, | ||
| 5 | viewportAspectRatio: number | null, | ||
| 6 | ): number | null { | ||
| 7 | return current === null || viewportAspectRatio === null ? null : viewportAspectRatio; | ||
| 8 | } | ||
| 9 | |||
| 10 | export async function commitViewportAndAspectRatio( | 3 | export async function commitViewportAndAspectRatio( |
| 11 | setting: PreviewViewportSetting, | 4 | setting: PreviewViewportSetting, |
| 12 | aspectRatio: number | null, | 5 | aspectRatio: number | null, |