Commit dcdb9ac92320d62028fd2d12be26167406666920 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-15 14:28:03-08:00
committer	Julius Marminge <julius0216@outlook.com> 2026-02-15 14:28:03-08:00
log	dcdb9ac92320d62028fd2d12be26167406666920
tree	33c34b22e0006565ac051ea31ffe6b8bbc1038e1
parent	46347e2bd273dd387d52b265691ab456d3e936be

Skip local-branch PR checks and dedupe sidebar git status

- server: only query open PRs when the current branch has an upstream; still fall back to merged PR lookup
- tests: cover status behavior for branches without upstream tracking
- web: fetch git status once per cwd, validate query data with schema parsing, and map merged PR badges by thread branch match

3 files changed, 58 insertions(+), 13 deletions(-)

apps
- server
  - src
    gitManager.test.ts
    gitManager.ts
- web
  - src
    components
    Sidebar.tsx

apps/server/src/gitManager.test.ts+22

...	@@ -242,6 +242,28 @@ describe("GitManager", () => {	...	@@ -242,6 +242,28 @@ describe("GitManager", () => {
242	expect(ghCalls.some((call) => call.includes("--state merged"))).toBe(true);	242	expect(ghCalls.some((call) => call.includes("--state merged"))).toBe(true);
243	});	243	});
244		244
		245	it("status skips open PR lookup for branches without upstream", async () => {
		246	const repoDir = makeTempDir("t3code-git-manager-");
		247	await initRepo(repoDir);
		248	await runGit(repoDir, ["checkout", "-b", "feature/local-only"]);
		249
		250	const { runner, ghCalls } = createRunnerWithFakeGh({
		251	prListSequence: ["[]"],
		252	});
		253
		254	const manager = new GitManager({
		255	runProcess: runner,
		256	textGenerator: createTextGenerator(),
		257	});
		258
		259	const status = await manager.status({ cwd: repoDir });
		260	expect(status.branch).toBe("feature/local-only");
		261	expect(status.openPr).toBeNull();
		262	expect(status.mergedPr).toBeNull();
		263	expect(ghCalls.some((call) => call.includes("--state open"))).toBe(false);
		264	expect(ghCalls.some((call) => call.includes("--state merged"))).toBe(true);
		265	});
		266
245	it("status is resilient to gh lookup failures and returns openPr/mergedPr null", async () => {	267	it("status is resilient to gh lookup failures and returns openPr/mergedPr null", async () => {
246	const repoDir = makeTempDir("t3code-git-manager-");	268	const repoDir = makeTempDir("t3code-git-manager-");
247	await initRepo(repoDir);	269	await initRepo(repoDir);

apps/server/src/gitManager.ts+7-4

 @@ -195,10 +195,13 @@ export class GitManager {
     let mergedPr: ReturnType<typeof toStatusOpenPr> | null = null;
     if (details.branch) {
       try {
-        const existing = await this.findOpenPr(input.cwd, details.branch);
+        if (details.hasUpstream) {
-        if (existing) {
+          const existing = await this.findOpenPr(input.cwd, details.branch);
-          openPr = toStatusOpenPr(existing);
+          if (existing) {
-        } else {
+            openPr = toStatusOpenPr(existing);
+          }
+        }
+        if (!openPr) {
           const merged = await this.findMergedPr(input.cwd, details.branch);
           if (merged) {
             mergedPr = toStatusOpenPr(merged);

apps/web/src/components/Sidebar.tsx+29-9

 @@ -1,7 +1,7 @@
 import { MonitorIcon, MoonIcon, SunIcon, TerminalIcon } from "lucide-react";
 import { useCallback, useEffect, useMemo, useState } from "react";
 import { useMutation, useQueries, useQueryClient } from "@tanstack/react-query";
-import type { GitStatusResult } from "@t3tools/contracts";
+import { gitStatusResultSchema, type GitStatusResult } from "@t3tools/contracts";
 import { isElectron } from "../env";
 import { useTheme } from "../hooks/useTheme";
 import { DEFAULT_MODEL } from "../model-logic";
 @@ -153,29 +153,49 @@ export default function Sidebar() {
       })),
     [projectCwdById, state.threads],
   );
+  const threadGitStatusCwds = useMemo(
+    () =>
+      [
+        ...new Set(
+          threadGitTargets
+            .filter((target) => target.branch !== null)
+            .map((target) => target.cwd)
+            .filter((cwd): cwd is string => cwd !== null),
+        ),
+      ],
+    [threadGitTargets],
+  );
   const threadGitStatusQueries = useQueries({
-    queries: threadGitTargets.map((target) => {
+    queries: threadGitStatusCwds.map((cwd) => {
-      const base = gitStatusQueryOptions(api, target.cwd);
+      const base = gitStatusQueryOptions(api, cwd);
       return {
         ...base,
-        enabled: Boolean(base.enabled && target.branch !== null),
+        enabled: Boolean(base.enabled),
         staleTime: 30_000,
         refetchInterval: 60_000,
       };
     }),
   });
   const mergedPrByThreadId = useMemo(() => {
+    const statusByCwd = new Map<string, GitStatusResult>();
+    for (let index = 0; index < threadGitStatusCwds.length; index += 1) {
+      const cwd = threadGitStatusCwds[index];
+      if (!cwd) continue;
+      const parsed = gitStatusResultSchema.safeParse(threadGitStatusQueries[index]?.data);
+      if (parsed.success) {
+        statusByCwd.set(cwd, parsed.data);
+      }
+    }
     const map = new Map<string, boolean>();
-    for (let index = 0; index < threadGitTargets.length; index += 1) {
+    for (const target of threadGitTargets) {
-      const target = threadGitTargets[index];
+      const status = target.cwd ? statusByCwd.get(target.cwd) : undefined;
-      if (!target) continue;
-      const status = threadGitStatusQueries[index]?.data as GitStatusResult | undefined;
       const branchMatches =
         target.branch !== null && status?.branch !== null && status?.branch === target.branch;
       map.set(target.threadId, branchMatches && status?.openPr === null && status?.mergedPr !== null);
     }
     return map;
-  }, [threadGitStatusQueries, threadGitTargets]);
+  }, [threadGitStatusCwds, threadGitStatusQueries, threadGitTargets]);
   const handleNewThread = useCallback(
     (projectId: string) => {