Commit feff86638ef7f08f6766350b8e84b151972eaaa7 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-03-02 16:42:46-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-03-05 23:00:41-08:00
log	feff86638ef7f08f6766350b8e84b151972eaaa7
tree	0d43efc232eaf8a6acfae60ad954a696e6fe6406
parent	ad28eaa86f851c6cd28573bd76635b550b43a530

Fix effort and provider handling in thread turn start

- Only include `effort` in start command when a value is selected
- Persist effort selection via composer draft state and hide picker when unavailable
- Add optional `provider` to `ClientThreadTurnStartCommand`
- Simplify thread model fallback selection in `ChatView`

2 files changed, 11 insertions(+), 14 deletions(-)

apps
- web
  - src
    components
    ChatView.tsx
packages
- contracts
  - src
    orchestration.ts

apps/web/src/components/ChatView.tsx+10-14

 @@ -2153,13 +2153,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
         }
       }
       const title = truncateTitle(titleSeed);
-      let threadCreateModel = selectedModel;
+      let threadCreateModel: ModelSlug = selectedModel || (activeProject.model as ModelSlug) || DEFAULT_MODEL;
-      if (!threadCreateModel) {
-        threadCreateModel = activeProject.model;
-      }
-      if (!threadCreateModel) {
-        threadCreateModel = DEFAULT_MODEL;
-      }
       if (isLocalDraftThread) {
         await api.orchestration.dispatchCommand({
 @@ -2228,7 +2222,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
         },
         model: selectedModel || undefined,
         provider: selectedProvider,
-        ...(supportsReasoningEffort ? { effort: selectedEffort } : {}),
+        ...(supportsReasoningEffort && selectedEffort ? { effort: selectedEffort } : {}),
         assistantDeliveryMode: settings.enableAssistantStreaming ? "streaming" : "buffered",
         approvalPolicy,
         sandboxMode,
 @@ -2387,7 +2381,7 @@ export default function ChatView({ threadId }: ChatViewProps) {
   );
   const onEffortSelect = useCallback(
     (effort: CodexReasoningEffort) => {
-      setSelectedEffort(effort);
+      setComposerDraftEffort(threadId, effort);
       scheduleComposerFocus();
     },
     [scheduleComposerFocus, setComposerDraftEffort, threadId],
 @@ -2850,11 +2844,13 @@ export default function ChatView({ threadId }: ChatViewProps) {
                     <Separator orientation="vertical" className="mx-0.5 hidden h-4 sm:block" />
                     {/* Reasoning effort */}
-                    <ReasoningEffortPicker
+                    {selectedEffort != null && (
-                      effort={selectedEffort}
+                      <ReasoningEffortPicker
-                      options={reasoningOptions}
+                        effort={selectedEffort}
-                      onEffortChange={onEffortSelect}
+                        options={reasoningOptions}
-                    />
+                        onEffortChange={onEffortSelect}
+                      />
+                    )}
                   </>
                 ) : null}

packages/contracts/src/orchestration.ts+1

...	@@ -348,6 +348,7 @@ export const ClientThreadTurnStartCommand = Schema.Struct({	...	@@ -348,6 +348,7 @@ export const ClientThreadTurnStartCommand = Schema.Struct({
348	text: Schema.String,	348	text: Schema.String,
349	attachments: Schema.Array(UploadChatAttachment),	349	attachments: Schema.Array(UploadChatAttachment),
350	}),	350	}),
		351	provider: Schema.optional(ProviderKind),
351	model: Schema.optional(TrimmedNonEmptyString),	352	model: Schema.optional(TrimmedNonEmptyString),
352	effort: Schema.optional(TrimmedNonEmptyString),	353	effort: Schema.optional(TrimmedNonEmptyString),
353	assistantDeliveryMode: Schema.optional(AssistantDeliveryMode),	354	assistantDeliveryMode: Schema.optional(AssistantDeliveryMode),