| author |  oliver <97427849+flamboh@users.noreply.github.com> 2026-09-07 12:57:52-07:00 |
| committer |  GitHub <noreply@github.com> 2026-09-07 16:57:52-03:00 |
| log | 72d94087b460e8d3d76572ed59fe935b80eb41a1 |
| tree | c2ae9876a6cb1276de584fdca1de56e3d0a2371a |
| parent | 62fbbe08aa854fcbd8044cd971a45a54edafcb98 |
| signature | Signed by PGP key B5690EEEBB952194 |
fix(web): restore settled PR colors on hover (#10023)
3 files changed, 9 insertions(+), 9 deletions(-)
apps
apps/web/src/components/Sidebar.tsx+1-3
| ... | @@ -1468,9 +1468,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: { | ... | @@ -1468,9 +1468,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: { |
| 1468 | // number from reflowing as PR states stream in. | 1468 | // number from reflowing as PR states stream in. |
| 1469 | "shrink-0 text-xs tabular-nums hover:underline", | 1469 | "shrink-0 text-xs tabular-nums hover:underline", |
| 1470 | variant === "slim" && variantAction === "unsettle" | 1470 | variant === "slim" && variantAction === "unsettle" |
| 1471 | ? props.isActive | 1471 | ? cn("text-secondary-label transition-colors", settledPrHoverClass) |
| 1472 | ? "text-secondary-label" | ||
| 1473 | : cn("text-secondary-label transition-colors", settledPrHoverClass) | ||
| 1474 | : prStatus.colorClass, | 1472 | : prStatus.colorClass, |
| 1475 | )} | 1473 | )} |
| 1476 | aria-label={prStatus.tooltip} | 1474 | aria-label={prStatus.tooltip} |
apps/web/src/components/ThreadStatusIndicators.test.ts+4-2
| ... | @@ -125,10 +125,12 @@ describe("settledPrHoverColorClass", () => { | ... | @@ -125,10 +125,12 @@ describe("settledPrHoverColorClass", () => { |
| 125 | ["merged", "text-violet-600"], | 125 | ["merged", "text-violet-600"], |
| 126 | ["closed", "text-red-600"], | 126 | ["closed", "text-red-600"], |
| 127 | ] as const)("restores the %s pull request color on row hover", (state, colorClass) => { | 127 | ] as const)("restores the %s pull request color on row hover", (state, colorClass) => { |
| 128 | expect(settledPrHoverColorClass(state)).toContain(`group-hover/v2-row:${colorClass}`); | 128 | expect(settledPrHoverColorClass(state)).toContain(`group-hover/sidebar-row:${colorClass}`); |
| 129 | }); | 129 | }); |
| 130 | 130 | ||
| 131 | it("keeps draft pull requests gray on row hover", () => { | 131 | it("keeps draft pull requests gray on row hover", () => { |
| 132 | expect(settledPrHoverColorClass("open", true)).toContain("group-hover/v2-row:text-zinc-500"); | 132 | expect(settledPrHoverColorClass("open", true)).toContain( |
| 133 | "group-hover/sidebar-row:text-zinc-500", | ||
| 134 | ); | ||
| 133 | }); | 135 | }); |
| 134 | }); | 136 | }); |
apps/web/src/components/ThreadStatusIndicators.tsx+4-4
| ... | @@ -86,13 +86,13 @@ export function settledPrHoverColorClass( | ... | @@ -86,13 +86,13 @@ export function settledPrHoverColorClass( |
| 86 | switch (state) { | 86 | switch (state) { |
| 87 | case "open": | 87 | case "open": |
| 88 | if (isDraft) { | 88 | if (isDraft) { |
| 89 | return "group-hover/v2-row:text-zinc-500 dark:group-hover/v2-row:text-zinc-400/80"; | 89 | return "group-hover/sidebar-row:text-zinc-500 dark:group-hover/sidebar-row:text-zinc-400/80"; |
| 90 | } | 90 | } |
| 91 | return "group-hover/v2-row:text-emerald-600 dark:group-hover/v2-row:text-emerald-300/90"; | 91 | return "group-hover/sidebar-row:text-emerald-600 dark:group-hover/sidebar-row:text-emerald-300/90"; |
| 92 | case "merged": | 92 | case "merged": |
| 93 | return "group-hover/v2-row:text-violet-600 dark:group-hover/v2-row:text-violet-300/90"; | 93 | return "group-hover/sidebar-row:text-violet-600 dark:group-hover/sidebar-row:text-violet-300/90"; |
| 94 | case "closed": | 94 | case "closed": |
| 95 | return "group-hover/v2-row:text-red-600 dark:group-hover/v2-row:text-red-300/90"; | 95 | return "group-hover/sidebar-row:text-red-600 dark:group-hover/sidebar-row:text-red-300/90"; |
| 96 | } | 96 | } |
| 97 | } | 97 | } |
| 98 | 98 |